Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h@... PS17, Line 69: u32 start32_offset; We should keep the addition of fields with the rest of the patches that utilize them. As things currently stand it seems these are just unused and can cause confusion.