Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move mainboard_get_dram_part_num to src/vendor/google/chromeos ......................................................................
Patch Set 8:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/45588/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45588/8/src/mainboard/google/dedede... PS8, Line 40: CHROMEOS_DRAM_PART_NUMBER_IN_CBI QUESTION: Should this be : select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if !ROMSTAGE_SPD_SMBUS
That holds true for puff, just not sure if the fact that ROMSTAGE_SPD_SMBUS is set means that they will get their SPD data through SMBUS instead and that they would never require ability to override the dram part number.