HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31423 )
Change subject: SMBIOS: Add new MEMORY_{TYPE,TECHNOLOGY,OPERATING} macros
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31423/2/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/#/c/31423/2/src/include/smbios.h@97
PS2, Line 97: MODE_CAP
MODE_CAP? Why not simply MODE? Or are you indicating it's a capability, and that more then 1 bit can […]
that does indicate supported modes, so it can be more than 1 bit.
If I remove "CAP", it can be confused with the current configured operating mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e466614d0a9e8c89f298594a5785af775b22a95
Gerrit-Change-Number: 31423
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment