[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 5: Code-Review+2

(2 comments)

LGTM (although I can't see where you're using it from yet?)

https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c@77 
PS5, Line 77: SCL0_EH
nit: maybe call them SCL0_EH_SHIFT/SCL0_RSEL_SHIFT to be clearer about what this is?

https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c@109 
PS5, Line 109: void gpio_set_i2c_eh_rsel(void)
Where are you calling this from? (I'd suggest bootblock_soc_init().)