LGTM (although I can't see where you're using it from yet?)
Patch set 5:Code-Review +2
2 comments:
File src/soc/mediatek/mt8183/gpio.c:
Patch Set #5, Line 77: SCL0_EH
nit: maybe call them SCL0_EH_SHIFT/SCL0_RSEL_SHIFT to be clearer about what this is?
Patch Set #5, Line 109: void gpio_set_i2c_eh_rsel(void)
Where are you calling this from? (I'd suggest bootblock_soc_init().)
To view, visit change 30974. To unsubscribe, or for help writing mail filters, visit settings.