Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )
Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG@9
PS3, Line 9: Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
: from every mainboard where 8 is used.
I would mention that *all* Broadwell boards use 8, which is the reason behind this change:
All Broadwell boards use 8 for MAX_CPUS, so this option can be factored out into SoC Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49122
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Gerrit-Change-Number: 49122
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Jan 2021 20:03:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment