Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )
Change subject: arch/x86: Top align bootblock program
......................................................................
Patch Set 4:
Patch Set 4:
The release requirement of !ROMCC_BOOTBLOCK triggered a side-effect when moving from top-aligned to bottom-aligned bootblock, there were some complaints of no longer being able to fit TianoCore payload on some installations with extremely tight SPI flash usage.
This commit targets for removal of a static C_ENV_BOOTBLOCK size. On my loal development trees I have tied the development of reduced-topology static devicetree for the bootblock to this, as well as development for 'CBMEM_CONSOLE-only bootblock, complex-console romstage with replay from CBMEM_CONSOLE'
On your request, this is now put on indefinete hold as well and is waiting for amd/picasso to progress.
Sorry. I wasn't trying to suggest stopping anything. I was responding to your specific question of adding new sections, but it sounds like my response was taken as sweeping for the whole patch. What are the conflicting changes in this patch vs development of another patch? Can they not proceed in tandem?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32518b1c19d08935727330314904b52a246af3c
Gerrit-Change-Number: 37895
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 27 Jan 2020 15:27:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment