Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32974 )
Change subject: soc/intel/common: Set GSPI clock value to prevent division by zero
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32974/1/src/soc/intel/common/block/gspi/gspi...
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/#/c/32974/1/src/soc/intel/common/block/gspi/gspi...
PS1, Line 442:
shouldn't the assert catch this?
Asserts aren't fatal by default in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32974
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a09474bff114c57d7a9c4c232bb636ff287e4d5
Gerrit-Change-Number: 32974
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 May 2019 17:06:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment