[coreboot-gerrit] Change in coreboot[master]: [TEST] Add support for link time optimization

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38989 )

Change subject: [TEST] Add support for link time optimization
......................................................................


Patch Set 3:

(2 comments)

(How do you guys manage to comment on this without clearing the WIP flag? Gerrit always forces me to click "START REVIEW" when I'm trying to reply...)

https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG@14 
PS3, Line 14: - The dead_code() macro causes linking errors, since dead functions
What exactly fails when you enable this? I took your patch, reverted the assert.h change and built GOOGLE_SCARLET (which uses that macro a bunch), and I didn't get any errors.

I like that macro a lot and would like to keep it alive. It serves a function that isn't easily duplicated with other means (you cannot do the same thing with just the preprocessor without making a giant mess).


https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig 
File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig@123 
PS2, Line 123: 	depends on COMPILER_GCC
> Assuming the board builds and boots with Clang first, we would need to use the llvm-* versions of bi […]
> Isn't clang not working anyway (and I believe efforts to fix it have pretty much stopped)? I think we've decided to support GCC only for the foreseeable future.