(How do you guys manage to comment on this without clearing the WIP flag? Gerrit always forces me to click "START REVIEW" when I'm trying to reply...)
2 comments:
Patch Set #3, Line 14: - The dead_code() macro causes linking errors, since dead functions
What exactly fails when you enable this? I took your patch, reverted the assert.h change and built GOOGLE_SCARLET (which uses that macro a bunch), and I didn't get any errors.
I like that macro a lot and would like to keep it alive. It serves a function that isn't easily duplicated with other means (you cannot do the same thing with just the preprocessor without making a giant mess).
Patch Set #2, Line 123: depends on COMPILER_GCC
Assuming the board builds and boots with Clang first, we would need to use the llvm-* versions of bi […]
Isn't clang not working anyway (and I believe efforts to fix it have pretty much stopped)? I think we've decided to support GCC only for the foreseeable future.
To view, visit change 38989. To unsubscribe, or for help writing mail filters, visit settings.