[coreboot-gerrit] Change in coreboot[master]: arch/x86: Implement RESET_VECTOR_IN_RAM

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )

Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35035/21/src/arch/x86/memlayout.ld 
File src/arch/x86/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/35035/21/src/arch/x86/memlayout.ld@... 
PS21, Line 56: #if !CONFIG(RESET_VECTOR_IN_RAM)
Not really resolved.

I have to assume that whoever put the guard here, discovered the segfault like 12 months ago and we already spent 20 times more time on this particular block review, compared to what I suspected would have been a oneliner fix in id.S.

Please change your workflows such that you alwaya leave TODOs on workarounds you implement, specially in common code. Preferably do not squash them with other works. They are higly likely to be resolved during community review, at latest.