[coreboot-gerrit] New patch to review for coreboot: 28404a8 Make H8 work by default

[Vladimir Serbinenko]

Vladimir Serbinenko ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4054

-gerrit

commit 28404a880d494d5fd2b7fa468850f80afece0ce4
Author: Vladimir Serbinenko 
Date:   Wed Nov 13 18:31:24 2013 +0100

Make H8 work by default

Currently H8 skips important init if unable to access CMOS config.
    Change default to enable all features to have a sane system without
    using CMOS config.

Change-Id: I94f39d9d2b4044d60f0cd7b7700bc8629e99201c
    Signed-off-by: Vladimir Serbinenko 
---
 src/ec/lenovo/h8/h8.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 9ffdfc1..ca34fb6 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -150,16 +150,17 @@ static void h8_enable(device_t dev)
    if (!get_option(&val, "volume"))
    	ec_write(H8_VOLUME_CONTROL, val);

+	if (get_option(&val, "bluetooth"))
+		val = 1;
+	h8_bluetooth_enable(val);

-	if (!get_option(&val, "bluetooth"))
-		h8_bluetooth_enable(val);
+	if (get_option(&val, "first_battery"))
+		val = 1;

-	if (!get_option(&val, "first_battery")) {
-		tmp = ec_read(H8_CONFIG3);
-		tmp &= ~(1 << 4);
-		tmp |= (val & 1)<< 4;
-		ec_write(H8_CONFIG3, tmp);
-	}
+	tmp = ec_read(H8_CONFIG3);
+	tmp &= ~(1 << 4);
+	tmp |= (val & 1) << 4;
+	ec_write(H8_CONFIG3, tmp);
    h8_set_audio_mute(0);
 }