Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38388 )
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Add comments for above 4GB mem range macro
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Thanks for the nice memory map diagrams, much appreciated :)
https://review.coreboot.org/c/coreboot/+/38388/1/src/soc/intel/apollolake/in...
File src/soc/intel/apollolake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/38388/1/src/soc/intel/apollolake/in...
PS1, Line 68: * Length is 2^36 = 64 GB.
i understand what your mean Aaron but how do i write the same is my confusion :( […]
As I understand it, the upper DRAM range goes from 4GiB till TOUUD.
However, I'm not sure what the 128 GiB base and 64 GiB size are, and what they correspond to in the diagram. :S
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe812031ea91932ec63adb030541b5ab5db8f425
Gerrit-Change-Number: 38388
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 13:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment