Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33409 )
Change subject: nb/intel/x4x: Die on unknown memory speed
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-1
We still have the same problem when 'u32 speed' is either zero or one.
Looking at the enum, those values should be 400 and 533. Do you think we could fill those in?
Those values are not supported by the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib628c0eed3d6571bdde1df27ae213ca0691ec256
Gerrit-Change-Number: 33409
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Jun 2019 20:45:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment