Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42807 )
Change subject: soc/amd/common: Separate single GPIO programming ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42807/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42807/4/src/soc/amd/common/block/gp... PS4, Line 195: soc_gpio_hook(gpio, mux); Can we get rid of this? Or replace with some assert to remove those soc_route_sci() calls inside soc_gpio_hook() implementation.
I find it somewhat intrusive that soc/ has this implicit override to change PAD_NF() to PAD_SCI() for GPIO_2. Or something like that, I could not exactly tell what this does.