Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, YH Lin.
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55113 )
Change subject: mb/google/volteer/var/volet: Update gpio and devicetree settings
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/mainboard/google/volteer/variants/volet/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55113/comment/aabc566f_c0fa90ee
PS2, Line 26: device i2c 1a on
: end
nit: […]
done
https://review.coreboot.org/c/coreboot/+/55113/comment/908ac5d7_300a500b
PS2, Line 44: device i2c 32 on
: end
done
https://review.coreboot.org/c/coreboot/+/55113/comment/d8d49330_6241afba
PS2, Line 112: 0x2c
Please be consistent with i2c address formats: […]
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0e9557e01ce1e7a49a3dddf6da3e4a29587a8b7
Gerrit-Change-Number: 55113
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 00:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment