Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38699 )
Change subject: soc/amd/picasso: Add UPD settings to chip.h
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h@...
PS7, Line 36: /* Options for these are in src/arch/x86/include/arch/acpi.h */
We do define them all: https://source.corp.google. […]
Ah okay. Sounds good. Let's keep it this way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bce44a43e57ba00d2b29cfa6249cef51e9ceabb
Gerrit-Change-Number: 38699
Gerrit-PatchSet: 7
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshall@marshalldawson.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 22:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment