Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41280 )
Change subject: security/tpm/tspi/crtm.c: Fix handling of white space delimited list ......................................................................
Patch Set 1:
``` CC bootblock/security/tpm/tspi/crtm.o src/security/tpm/tspi/crtm.c: In function 'is_runtime_data': src/security/tpm/tspi/crtm.c:93:2: error: ISO C90 forbids variable length array 'tmp_whitelist' [-Werror=vla] char tmp_whitelist[whitelist_len + 1]; ^~~~ src/security/tpm/tspi/crtm.c:100:10: error: implicit declaration of function 'strtok'; did you mean 'strspn'? [-Werror=implicit-function-declaration] token = strtok(tmp_whitelist, delim); ^~~~~~ strspn src/security/tpm/tspi/crtm.c:100:8: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] token = strtok(tmp_whitelist, delim); ^ src/security/tpm/tspi/crtm.c:105:9: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] token = strtok(NULL, delim); ^ ```