Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78522?usp=email )
Change subject: soc/intel/cannonlake: Implement SoC sleep state array
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/cannonlake/chip.c:
https://review.coreboot.org/c/coreboot/+/78522/comment/f70befbc_89791b7a :
PS1, Line 130: case PCH_DEVFN_EMMC: return "PEMC";
why change this name?
to match the actual ACPI device name in `src/soc/intel/cannonlake/acpi/scs.asl.` I could change that one to `EMMC` if it makes more sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78522?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib2c733c04e29f0f9e7e2e6dbf36c2a7618fdc23f
Gerrit-Change-Number: 78522
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 31 Oct 2023 13:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment