Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46042 )
Change subject: drivers/camera: Add cros camera info ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46042/1/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/camera.h:
https://review.coreboot.org/c/coreboot/+/46042/1/src/vendorcode/google/chrom... PS1, Line 18: uint16_t module_revision; : uint8_t module_vendor[2]; : uint8_t sensor_vendor[2]; : uint16_t sensor_model; :
Could we call these module_pid, module_vid, sensor_vid, sensor_pid respectively, to match the later […]
Should we use uint16_t for *_vid?
https://review.coreboot.org/c/coreboot/+/46042/1/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/camera.c:
https://review.coreboot.org/c/coreboot/+/46042/1/src/vendorcode/google/chrom... PS1, Line 16: &info->version;
nit: Would it make sense to make it (void *)(&info->crc16 + 1), so that it always covers all the fie […]
Done