Attention is currently required from: Julius Werner, Nick Vaccaro, Yu-Ping Wu.
Vladimir Serbinenko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81508?usp=email )
Change subject: Support for creating hybrid vboot images ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
- RW needs to stay the same as changing it would break ChromeOS mechanism […]
Sorry, I missed a word: "with chromeos update mechanism". I used a custom depthcharge and it worked fine until update time came for ChromeOS. As part of update ChromeOS does firmware update even if the firmware didn't change. Update suceeds in either of 2 cases: 1) RO is writable. Then it reflashes both RO and RW 2) RO is locked but it's compatible with new RW. Compatible means same layout and same GBB keys.
Then, bigger problem is that flash map is preloaded 2 times: 1) Inside the code that ends up referencing partition by fixed offsets instead of reading flashmap 2) In CAR. And the size of preloaded cache is exact: it means it has as many slots as there are partitions and loading any extras will cause panic. It can't be extended because next allocation in CAR follows. These 2 together preclude adding any partitions which makes it a necessity to find another place for SMMSTORE
As for bootblock: it's a good possibility but isn't the code I modify part of bootblock?