Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41375 )
Change subject: nb/intel/sandybridge: Do not hardcode resource indices
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41375/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41375/1/src/northbridge/intel/sandy...
PS1, Line 138: 3
I know you just preserve the behavior. I'm asking questions anyway :-P probably […]
I checked, and this had been hardcoded since forever (ever since sandybridge was added)
I don't know how to handle that without doing some major refactoring, though. If you want, I can add FIXMEs to all hardcoded indices
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8719a1a5973a10531cf11b3307652212cb3d4895
Gerrit-Change-Number: 41375
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 16 May 2020 10:06:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment