Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39999 )
Change subject: soc/amd/common/psp: Consolidate FW blob load functions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps...
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps...
PS1, Line 312: (type == BLOB_SMU_FW || type == BLOB_SMU_FW2)
It's been a while since I've considered this, however I'd likely done it intentionally to cover the […]
i removed this now; should i add a comment about the removed additional checks that are currently always true?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39999
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a4926175d50c01b70ff9b10908c38b3cbe8f35
Gerrit-Change-Number: 39999
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 15:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment