[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Enable Intel Speed Shift Technology

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39477 )

Change subject: mb/google/dedede: Enable Intel Speed Shift Technology
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39477/5/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledee/variant.c:

https://review.coreboot.org/c/coreboot/+/39477/5/src/mainboard/google/dedede... 
PS5, Line 13: where board version is not populated.
> Does it always return -1 or can the return value be 0 and board_ver = 0xffffffff?

If EC returns error, get board version returns -1. EC returns error on the boards where board version is not populated.

EC Logs:
2020-05-20 11:44:07 [1.679129 Failed (1) getting board version]
2020-05-20 11:44:07 [1.679664 HC 0x06 err 2]

BIOS logs:
EC returned error result code 2