Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40524 )
Change subject: mb/ocp/tiogapass: Populate SMBIOS data and set the read PPIN to BMC ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40524/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40524/2//COMMIT_MSG@14 PS2, Line 14:
Please remove the blank line.
Done
https://review.coreboot.org/c/coreboot/+/40524/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ipmi.h:
https://review.coreboot.org/c/coreboot/+/40524/2/src/mainboard/ocp/tiogapass... PS2, Line 16: uint32_t CPU0lo;
coreboot prefers lowercase variable names.
Done
https://review.coreboot.org/c/coreboot/+/40524/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ipmi.c:
https://review.coreboot.org/c/coreboot/+/40524/2/src/mainboard/ocp/tiogapass... PS2, Line 23: printk(BIOS_INFO, "IPMI Set PPIN done.\n");
The current style suggests, it’s a debug message. For BIOS_INFO, please improve the wording.
Changed to BIOS_DEBUG.