Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specify dedicated chipset name ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(1 comment)
I had attempted this in past, had a review comment (below) on why order in required:
" Order might matter here, that `common/Kconfig` is sourced last is likely intentional.
Usually this is done so that the common code can provide a default and SoCs can override it (first `default` line encountered by Kconfig takes precedence)."
Correct. I think we can potentially do this:
Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common Change: All specific SoC sources to "source src/soc/intel/*/Kconfig" Change: Common source to "source src/soc/intel/common/Kconfig.common"
Sure, let me do that as mentioned here