Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )
Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon
......................................................................
Patch Set 11:
(1 comment)
Patch Set 5: Code-Review+1
(2 comments)
Ok, will use t
https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut...
File src/soc/qualcomm/qcs405/qclib_execute.c:
https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut...
PS4, Line 78: 0x8c111a0
PBL_DATA_PTR_ES_1_1
Ok, will cleanup dead code and also use Macros, for this and other places
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84
Gerrit-Change-Number: 30903
Gerrit-PatchSet: 11
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yuji Sasaki
sasakiy@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 27 Feb 2019 10:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment