27 Jan
2019
27 Jan
'19
10:48 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30904 )
Change subject: Revert "vboot: Fix linking error with USE_OPTION_TABLE enabled" ......................................................................
Patch Set 3:
Patch Set 3:
IMO it makes sense to put the option table in cbmem to cache it. Also avoid this kind of issues...
You would have to keep both in sync, which seems as difficult as it's now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a13be56d47dc8373d9c6d556505bb2e3674d4a8
Gerrit-Change-Number: 30904
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nathaniel Roach nroach44@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Joseph Samuel Pacheco-Corwin hammersamatom@gmail.com
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Mon, 28 Jan 2019 05:48:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment