Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40515 )
Change subject: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC ......................................................................
Patch Set 4: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/40515/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40515/4//COMMIT_MSG@9 PS4, Line 9: This change Normally redundant phrasing in commit messages.
https://review.coreboot.org/c/coreboot/+/40515/4//COMMIT_MSG@10 PS4, Line 10: any device that is sitting behind the Chrome EC. It accepts a config With HID GOOG0012?
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... File src/ec/google/chromeec/i2c_tunnel/Kconfig:
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 6: SSDT nodes for I2C tunnel used by the mainboard. for *the* I2C ?
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... File src/ec/google/chromeec/i2c_tunnel/chip.h:
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 3: * No blank line? Angel?
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 14: int unsigned int?
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 16: int unsigned int?