Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36921 )
Change subject: soc/mediatek/mt8183: TX RX window should not do fast K for High frequency ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... PS3, Line 1593: 796 how this was calculated? I know it's freq/2, but why -4 ? can you add some comment?
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... PS3, Line 1648: clock_rate this looks like doubled. Are you sure we don't need to /2 or something?