Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35463/1/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/1/src/include/device/mmio.h@8... PS1, Line 89: #define DEFINE_BITFIELD(name, start, end) \
Macros with multiple statements should be enclosed in a do - while loop
we probably won't fix this because we do need range checking, but enum also need to be declared outside do-while block.
https://review.coreboot.org/c/coreboot/+/35463/1/src/include/device/mmio.h@1... PS1, Line 116: #define _BF_APPLYINVALID(...) \
macros should not use a trailing semicolon
Done