Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37645 )
Change subject: mb/google/hatch: Add mushu variant ......................................................................
Patch Set 6:
(6 comments)
Mushu variant is initially mirroring Hatch reference. It is expected to change over time.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 11: [PchSerialIoIndexSPI1] = PchSerialIoPci,
This is off later in the devtree.
Switched to mirror Hatch reference laptop.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 26: RFU
The meaning of "RFU" isn't obvious. I'd rather use the full "Reserved for future use" phrase.
Switched to mirror Hatch reference laptop.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 27: PS175
What is this? I would rather specify the function of this device (touchscreen, touchpad, scaler... […]
Switched to mirror Hatch reference laptop.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 28: MST
Multi Stream Transport
Switched to mirror Hatch reference laptop.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 36: i2c[0]
This is disabled, so I guess this could be dropped
Switched to mirror Hatch reference laptop.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 41: .i2c[1]
Did you mean `. […]
Switched to mirror Hatch reference laptop.