Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Compile smm files based on CONFIG_SMM_INDEPENDENT_BUILD ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33115/4/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/33115/4/src/Kconfig@333 PS4, Line 333: default y if STAGE_RAMSTAGE || RAMPAYLOAD I'm not following why the default would be based on these things. I think you should have another Kconfig which is the negative of this one such that you can select it for the small number of platforms that would deselect smm. Then the default of this option would be !that_option.
Also, as this option is x86 dependent it should go in src/arch/x86
https://review.coreboot.org/#/c/33115/4/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/33115/4/src/arch/x86/Makefile.inc@403 PS4, Line 403: ifeq ($(CONFIG_SMM_INDEPENDENT_BUILD),y) I still don't follow why this change is needed. I think some work is required in src/cpu/x86/smm as well as a few guards in the code to not include the root reference which pulls everything in.