Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 13: DRIVERS_UART_ACPI if !AMD_LPC_DEBUG_CARD
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 14: PICASSO_CONSOLE_UART Can Picasso's UARTs work in non-ACPI mode? If not, I'd select DRIVERS_UART_ACPI in PICASSO_CONSOLE_UART