[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )

Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... 
File src/soc/intel/icelake/Kconfig:

https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... 
PS10, Line 24: 	select HAVE_FSP_GOP if !ENABLE_DISPLAY_OVER_EXT_PCIE_GFX
> That's unrelated to HAVE_FSP_GOP. […]

fixed now

https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... 
PS10, Line 211: 	select ALWAYS_LOAD_OPROM
> that conflicts with "Graphics initialization" menu, it only allows you to select VGA_ROM_RUN. […]

very good point, thanks i have missed that, i was always getting display earlier. now i have verified that with GBB flag 0x39, i'm seeing pre-os display and 0x0 won't bring display