Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... PS6, Line 36: if (config->InternalGfx == 0) {
struct device *dev = pcidev_path_on_root(SA_DEVFN_IGD); […]
Looking at skylake, it's even better. Instead of using config->InternalGfx the "pci 2.0" device in the devicetree.cb could be used to enable/disable graphics. Something similar to:
struct device *dev = pcidev_path_on_root(SA_DEVFN_IGD); if (!dev || !dev->enabled || (dev && pci_read_config32(dev, PCI_VENDOR_ID) == 0xffff)) )