Attention is currently required from: Angel Pons, Felix Held, Harrie Paijmans.
Maxim Polyakov has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/87273?usp=email )
Change subject: superio/fintek/f81866d: Fix HWM port address
......................................................................
Patch Set 1:
(1 comment)
File src/superio/fintek/f81866d/f81866d_hwm.c:
https://review.coreboot.org/c/coreboot/+/87273/comment/f1a01625_10d53685?usp... :
PS1, Line 51: pnp_enter_conf_mode(dev);
Just like in the f81966, there is no need to set the configuration mode for HWM.
We already have CB:87274 for this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87273?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If39400e56a7d0792a5bc8f312c29dd5e98a0b2d3
Gerrit-Change-Number: 87273
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 11 Apr 2025 09:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Harrie Paijmans
hpaijmans@eltan.com