Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31010 )
Change subject: mb/purism/librem_skl: add 13v3 variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31010/1/src/mainboard/purism/librem_skl/Kcon... File src/mainboard/purism/librem_skl/Kconfig:
https://review.coreboot.org/#/c/31010/1/src/mainboard/purism/librem_skl/Kcon... PS1, Line 24: default "librem13v2" if BOARD_PURISM_LIBREM13_V2 : default "librem13v2" if BOARD_PURISM_LIBREM13_V3 : default "librem15v3" if BOARD_PURISM_LIBREM15_V3 : default "librem13v2" if BOARD_PURISM_LIBREM13_V4 : default "librem15v3" if BOARD_PURISM_LIBREM15_V4 : : config MAINBOARD_VENDOR : string : default "Purism" : : config MAINBOARD_FAMILY : string : default "Librem 13" if BOARD_PURISM_LIBREM13_V2 : default "Librem 13" if BOARD_PURISM_LIBREM13_V3 : default "Librem 15" if BOARD_PURISM_LIBREM15_V3 : default "Librem 13" if BOARD_PURISM_LIBREM13_V4 : default "Librem 15" if BOARD_PURISM_LIBREM15_V4 : : config MAINBOARD_PART_NUMBER : string : default "Librem 13 v2" if BOARD_PURISM_LIBREM13_V2 : default "Librem 13 v2" if BOARD_PURISM_LIBREM13_V3 : default "Librem 15 v3" if BOARD_PURISM_LIBREM15_V3 : default "Librem 13 v4" if BOARD_PURISM_LIBREM13_V4 : default "Librem 15 v4" if BOARD_PURISM_LIBREM15_V4 : : config MAINBOARD_VERSION : string : default "2.0" if BOARD_PURISM_LIBREM13_V2 : default "3.0" if BOARD_PURISM_LIBREM13_V3 : default "3.0" if BOARD_PURISM_LIBREM15_V3 : default "4.0" if BOARD_PURISM_LIBREM13_V4 : default "4.0" if BOARD_PURISM_LIBREM15_V4
wouldn't it be better to use '||' per 'default' entries.
had that originally, but with 3 BOARD_ entries for some lines, makes them excessively long and difficult to read, so used the same format for all entries