Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44480/17/src/soc/amd/picasso/Makefi...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44480/17/src/soc/amd/picasso/Makefi...
PS17, Line 396: echo "RCB: " $(if $(APCB_POPULATE_2ND_CHANNEL), --spd_1_0 $<, )
Is this required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5
Gerrit-Change-Number: 44480
Gerrit-PatchSet: 17
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 28 Aug 2020 15:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment