Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48223 )
Change subject: mb/google/volteer: ACPI nodes for volteer2_ti50 ......................................................................
Patch Set 3: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... PS3, Line 205: GOOG0005
Is there any reason to use a new ID for Ti50? If the i2c kernel driver works as is that is fine, bu […]
Good point. I had missed that the HID used was different than other I2C cr50 devices.
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee... PS3, Line 207: off
Do we want to allocate a bit in fw_config for this so you don't need the messy code to enable/disabl […]
I didn't suggest that because it takes away another bit from FW_CONFIG space for all variants.