Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47875 )
Change subject: soc/amd/common/block/cpu: move CAR-specific Makefile to sub-directory
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47875/1/src/soc/amd/common/block/cp...
File src/soc/amd/common/block/cpu/car/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47875/1/src/soc/amd/common/block/cp...
PS1, Line 1: ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_CAR),y)
Guard is unnecessary
oh, right. I wonder if it would be better to drop the guard here or in the makefile in the parent folder; the common pattern is that the parent makefile includes all makefiles in the folders below and those have the guards. might be a good idea to switch over to that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47875
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43a3039237d96e02baa33488e71c5f24effe8359
Gerrit-Change-Number: 47875
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 22:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment