Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35745 )
Change subject: soc/skylake/fsp: enable PCIe Advanced Error Reporting (AER) by default
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35745/1/src/soc/intel/skylake/chip_...
File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35745/1/src/soc/intel/skylake/chip_...
PS1, Line 300: CONFIG_MAX_ROOT_PORTS
we could do something like min(ARRAY_SIZE(PcieRpAdvancedErrorReporting), CONFIG_MAX_ROOT_PORTS)
They are supposed to be the same... it's a Kconfig setting, and always 24 for this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I172329d8d42c3be02e64300675d646edfbee8b72
Gerrit-Change-Number: 35745
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 06 Oct 2019 20:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment