Attention is currently required from: Chris Wang, chris wang.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52709 )
Change subject: mb/google/mancomb: Add STAPM values to overridetree
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/mancomb/variants/mancomb/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52709/comment/c9559251_7725b5b7
PS1, Line 3: register "system_configuration" = "3"
This isn't wrong here, but it should go in the top level devicetree since it's going to be the same for all the mancomb platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7
Gerrit-Change-Number: 52709
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment