Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37187 )
Change subject: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37187/3/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37187/3/src/soc/intel/cannonlake/bo...
PS3, Line 45: Length
For what it's worth, it still doesn't work. Neither with this line fixed nor […]
@Sheng/Praveen, can you please help Nico to unblock FSP-T usage. as per David and my test, i don't see any issue on our platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a406fa0e2e62e3363c2960e173dc5f5f5ca0455
Gerrit-Change-Number: 37187
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Vincent Zimmer
vincent.zimmer@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 02:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment