Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )
Change subject: mb/google/hatch: Configure miscellaneous features
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/...
PS8, Line 53: # Enable heci communication
: register "HeciEnabled" = "1"
oh yes, i just realized that Intel don't claim to disable CSME in boot flow hence there shouldn't be […]
Currently, hecienabled=1 causes a boot hang. Shelley is looking into it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea90a65a77ef5e45a802cfe6fd31e1921163b02b
Gerrit-Change-Number: 30774
Gerrit-PatchSet: 8
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Jan 2019 15:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment