Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48424 )
Change subject: asus/a88xm-e: properly program the IRQ tables ......................................................................
Patch Set 4:
(24 comments)
File src/mainboard/asus/a88xm-e/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/9c304065_ca20359a PS4, Line 28: {IOMMU_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* IOMMU: 0:00.02 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/01098f7b_d488ea99 PS4, Line 29: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/ebd4c7a9_1515558d PS4, Line 30: {ACTL_DEVFN, {PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC} }, /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/edbecbe7_13874b75 PS4, Line 31: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* PCIe GPP to dGPU 1:00.00: 0:02.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/958e1f47_d1e7ac42 PS4, Line 32: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* PCIe GPP to 2:00.00: 0:04.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/4506b7c3_a91d359e PS4, Line 33: {NB_PCIE_PORT4_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* PCIe GPP to 3:00.00: 0:05.00 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/41d180b5_1c0f5341 PS4, Line 34: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* PCIe GPP to Eth 4:00.00: 0:06.00 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/2b33db1e_32dba284 PS4, Line 35: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB XHCI: 0:10.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/dd17cb23_6be88549 PS4, Line 36: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* SATA: 0:11.00 - IRQ 7 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/714068b4_33336564 PS4, Line 37: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI1: 0:12.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/385990de_e659ab1c PS4, Line 38: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC} }, /* USB EHCI1: 0:12.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/dd4450bf_cf7ae5db PS4, Line 39: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI2: 0:13.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/5ac63466_51c4a7dd PS4, Line 40: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC} }, /* USB EHCI2: 0:13.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/fcdad215_d1781a17 PS4, Line 41: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI3: 0:16.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/a63443c5_00bb78f6 PS4, Line 42: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC} }, /* USB EHCI3: 0:16.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/4c7c2c76_d08b3d89 PS4, Line 43: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/1ab6e49b_2e1cfe2a PS4, Line 44: {SB_PCI_PORT_DEVFN, {PIRQ_E, PIRQ_F, PIRQ_NC, PIRQ_NC} }, /* Southbridge PCI Port: 0:14.04 - IRQ 11 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/b6b9d406_b4f2fa11 PS4, Line 45: {OHCI4_DEVFN, {PIRQ_NC, PIRQ_NC, PIRQ_OHCI4, PIRQ_NC} }, /* USB OHCI4: 0:14.05 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/a91382e7_91fcc4c8 PS4, Line 46: {SB_PCIE_PORT1_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* Southbridge PCIe Port 1: 0:15.00 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/44b517dd_a762a031 PS4, Line 47: {SB_PCIE_PORT2_DEVFN, {PIRQ_C, PIRQ_D, PIRQ_A, PIRQ_B} }, /* Southbridge PCIe Port 2: 0:15.01 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/f8db01d4_6282dd2a PS4, Line 48: {SB_PCIE_PORT3_DEVFN, {PIRQ_D, PIRQ_A, PIRQ_B, PIRQ_C} }, /* Southbridge PCIe Port 3: 0:15.02 - IRQ 7 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/bed522ce_34350525 PS4, Line 49: {SB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} } /* Southbridge PCIe Port 4: 0:15.03 - IRQ 3 */ line over 96 characters
File src/mainboard/asus/a88xm-e/mptable.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/778b3d41_3ad23e0f PS4, Line 126: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127242): https://review.coreboot.org/c/coreboot/+/48424/comment/8afe14ca_6b85e52e PS4, Line 225: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters