Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44837 )
Change subject: mb/getac/p470: Use PNP_IDX_EN instead of magic number ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44837/1/src/mainboard/getac/p470/ea... File src/mainboard/getac/p470/early_init.c:
https://review.coreboot.org/c/coreboot/+/44837/1/src/mainboard/getac/p470/ea... PS1, Line 79: pnp_write_config(dev, PNP_IDX_EN, (0x600 >> 4)); // Runtime Register Block Base I'm unsure if this one is semantically correct, since the SMSC SIO chips are the ones that don't follow the LDN layout from appendix A of the plug and play ISA specification and the comment points in some other direction. Haven't checked the datasheet