Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44375 )
Change subject: libpayload: cbgfx: Add color mapping functionality
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44375/3/payloads/libpayload/drivers...
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/3/payloads/libpayload/drivers...
PS3, Line 59: = {
: .x = 0,
: .y = 0,
: };
This is just a matter of taste, there is no hard rule... […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I640ff3e8455cd4aaa5a41d03a0183dff282648a5
Gerrit-Change-Number: 44375
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Aug 2020 22:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment