Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41911 )
Change subject: [NOTFORMERGE]acpi: Get rid of boilerplate FADT
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41911/2/src/acpi/acpi.c
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/41911/2/src/acpi/acpi.c@1269
PS2, Line 1269: fadt->reset_value = RST_CPU | SYS_RST;
This probably needs preprocessor to build on non-x86 (undefined macros are compiler errors)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5dd79e001a2bae71ad99ec7d5dfb7d1a6a020a1
Gerrit-Change-Number: 41911
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 May 2020 10:40:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment