Attention is currently required from: Anson Tseng, Daniel Peng, Derek Huang, Paul Menzel, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76542?usp=email )
Change subject: mb/google/dedede/var/pirika: Support for Samsung K4U6E3S4AB-MGCL
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/76542/comment/9e686a26_c2be25ea :
PS4, Line 4: /tmp/go-build352956073/b001/exe/part_id_gen
The changed was modified automatically after run command. […]
It seems this is an artifact of "go run" which compiles the source code, installs the executable in a /tmp path and then executes it from there. There is nothing wrong with that. This line will not change if you run "go build" followed by executing the binary explicitly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76542?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief9bbf11fc05c8155f1da7188926a29dbbfbe488
Gerrit-Change-Number: 76542
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anson Tseng
ansontseng@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 16:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-MessageType: comment